Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a preliminary go at #598!
This PR implements a C++ wrapper around the C API to cut down on some of the verbosity of using ADBC from C++ and ensure the assumptions made by drivers (e.g., that parent objects are valid). One of the difficulties of building an ADBC driver is testing it...the validation library helps here but is still rather verbose. I'm hoping this will help make it easier to write great tests for new drivers!
Current syntax:
The implementation is probably more verbose than it has to be but has some nice properties:
AdbcXXX()
symbols (so it can be used by a driver like DuckDB and/or a future GDAL to federate from ADBC sources while also being an ADBC driver itself)get_next()
!)Work in progress!